Add tests for tar #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! If you need to pull in another library to compress files, I'd rather just put them in the repo. I'm not against that, but when you can use the stdlib or already-available open source package we use, go ahead and create the files. The tests also run on Windows, so os.exec is going to be a problem. Again, just create some test files and include them. |
davidnewhall
approved these changes
Jul 1, 2024
|
Thank you for the invite to collaborate - I am humbled. Let me know @davidnewhall if it is OK to merge. |
davidnewhall
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is no library for compressing using the traditional Z format, so I added a test file for this
added a new dependency for writing bzip2
there was also a typo in the error message in tar.go that I fixed